ci(mkosi): title guest OS releases after the product, not the backend - #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mkosi release job publishes with
--title "$TAG", and the tag ismkosi-os-v<version>. That prefix exists only so this workflow's tag trigger cannot collide with the Yocto guest-OS one — it is a CI implementation detail, not a product name. It nevertheless ends up as the release name users read on the releases page, next to entries likeVerifier Release v0.5.11anddstack-sdk 0.1.3:The last release had to be renamed by hand afterwards to read as a dstack guest OS release, which is not something a publish path should require.
Fix
Title the release
dstack OS v$VERSIONinstead of echoing the tag. The tag itself is unchanged, so the trigger, themkosi-os-v*tag-format check anddocs/rc-testing-runbook.mdall stay as they are.VERSIONis the build job's output, read fromos/mkosi/versions.env, and the preceding validation step already fails the job unless the tag equalsmkosi-os-v$DSTACK_VERSION. So the title cannot drift from the tag or from the image's ownmetadata.jsonversion.Verification
gh release liston this repo confirms the current title is the raw tag and that no other release advertises a build backend.yaml.safe_loadand re-read theCreate the releasestep; the diff is the--titlevalue plus a comment.VERSION=0.6.0→dstack OS v0.6.0.Release-notes body, assets,
--verify-tagand--prereleaseare untouched.